Raise exceptions rather than return None in all jsonrpc calls #1218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
njgheorghita
force-pushed
the
raise-exceptions-in-web3-eth
branch
from
e94441c
to
2ac48f6
Compare
|
@pipermerriam What other |
njgheorghita
force-pushed
the
raise-exceptions-in-web3-eth
branch
2 times, most recently
from
80a0da7
to
0cb275b
Compare
njgheorghita
changed the title
njgheorghita
force-pushed
the
raise-exceptions-in-web3-eth
branch
from
0cb275b
to
5f3eb60
Compare
njgheorghita
force-pushed
the
raise-exceptions-in-web3-eth
branch
from
e8d6fc3
to
56bea98
Compare
|
@pipermerriam ping for review |
kclowes
approved these changes
Feb 27, 2019
njgheorghita
commented
Feb 28, 2019
| @@ -107,6 +110,9 @@ def request_blocking(self, method, params): | |||
| if "error" in response: | |||
| raise ValueError(response["error"]) | |||
|
|
|||
| if response['result'] is None: | |||
| raise ValueError(f"The call to {method} did not return a value.") | |||
dylanjw
approved these changes
Feb 28, 2019
dylanjw
approved these changes
Feb 28, 2019
| @@ -107,6 +110,9 @@ def request_blocking(self, method, params): | |||
| if "error" in response: | |||
| raise ValueError(response["error"]) | |||
|
|
|||
| if response['result'] is None: | |||
| raise ValueError(f"The call to {method} did not return a value.") | |||
pipermerriam
reviewed
Mar 4, 2019
| @@ -485,8 +485,8 @@ def test_eth_getBlockByHash(self, web3, empty_block): | |||
| assert block['hash'] == empty_block['hash'] | |||
|
|
|||
| def test_eth_getBlockByHash_not_found(self, web3, empty_block): | |||
| block = web3.eth.getBlock(UNKNOWN_HASH) | |||
| assert block is None | |||
| with pytest.raises(ValueError): | |||
There was a problem hiding this comment.
I realize that I'm late to the party on this one, but I think that this should be a custom exception for each object type.
BlockNotFoundTransactionNotFound(use this for receipt fetching too)- anything else?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
#722 (comment)
How was it fixed?
Raised a
ValueErrorif return value fromManager._make_request()isNoneCute Animal Picture