Improvements to merge_args_and_kwargs
#1228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davesque
force-pushed
the
merge-args-kwargs
branch
from
01ed5a2
to
575cb66
Compare
|
@pipermerriam That's funny. When I saw that @kclowes was requested to review this, I thought I had done that myself. Then I thought I should request a review from you as well just for good measure. Since you actually requested the review, I'll just assume you were delegating to her on this one. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
I was finding the
merge_args_and_kwargsutility function to be hard to understand without a fair bit of effort. I also noticed a couple of minor inefficiencies in the implementation.How was it fixed?
Added an explanatory docstring, comments, useful whitespace, and made some minor refactors to improve readability and efficiency.
Cute Animal Picture