Deprecate no infura api key in v5 #1247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think we should probably schedule the exception raising around a week before that date at the very latest to give people time to respond. While this is technically a breaking change, I do think it should be backported to v4 since users would encounter a less friendly error message if we don't and thus, it's a breaking change either way. |
kclowes
changed the title
kclowes
force-pushed
the
deprecate-no-infura-api-key
branch
from
844a26c
to
5856aac
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
Starting March 27th, Infura will officially stop supporting requests with no API key. Infura calls it a project ID, so I allow users to use either
WEB3_INFURA_API_KEY, orWEB3_INFURA_PROJECT_IDenv var. I took out the ability to useINFURA_API_KEYfor this branch, but will leave it in for the v4 branch.There is already a warning in place if there is no API key, but I updated the message. After March 27th, we should consider throwing an error if there is no key so the user can have a nice message.
Related to Issue #1246
How was it fixed?
See above.
Cute Animal Picture