-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Relocate eth_protocolVersion and web3_clientVersion #1274
Relocate eth_protocolVersion and web3_clientVersion #1274
Conversation
Now that |
a9a3176
to
6f03c1d
Compare
6f03c1d
to
e0ec4ac
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me @njgheorghita!
@@ -0,0 +1,2 @@ | |||
def test_eth_protocolVersion(web3): | |||
assert web3.eth.protocolVersion == '99' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this 99?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe it's talking to eth-tester
and should probably be updated internally to be 63
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmmm, strange - according to this line it should be returning 63
. Will dive deeper into this tomorrow
* Delegates to ``web3_clientVersion`` RPC Method | ||
|
||
Returns the current client version. | ||
|
||
.. code-block:: python | ||
|
||
>>> web3.version.node | ||
>>> web3.clientVersion |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know this is merged already, but I noticed that there isn't documentation for web3.clientVersion
. Do you mind adding it when you get a chance? 🙏
What was wrong?
eth_protocolVersion
endpoint fromweb3.version.ethereum
toweb3.eth.protocolVersion
web3_clientVersion
endpoint fromweb3.version.node
toweb3.clientVersion
Upon approval of this pr, I'll create a pr to raise deprecation warnings in v4
Cute Animal Picture