Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove web3/utils folder #1282

Merged
merged 2 commits into from
Mar 15, 2019
Merged

Remove web3/utils folder #1282

merged 2 commits into from
Mar 15, 2019

Conversation

kclowes
Copy link
Collaborator

@kclowes kclowes commented Mar 15, 2019

What was wrong?

An importerror was getting thrown because of the no longer existing compat module that was getting imported in web3/utils/__init__.py

Related to Issue #1281

How was it fixed?

Removed the utils folder since we don't need it for backwards compatibility in v5

Cute Animal Picture

download

Copy link
Member

@pipermerriam pipermerriam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably worth adding to release notes. Not sure what you're workflow on this project has become but I think what's being done in Trinity is worth adopting, appending to an unreleased section.

@kclowes
Copy link
Collaborator Author

kclowes commented Mar 15, 2019

Ah, I like that. Done!

@kclowes kclowes merged commit af2cdbd into ethereum:master Mar 15, 2019
@kclowes kclowes deleted the remove-utils branch March 15, 2019 17:43
@carver carver mentioned this pull request Apr 4, 2019
22 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants