V5 upgrade guide #1284
Merged
V5 upgrade guide #1284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These got deleted before they could go through a deprecation cycle
kclowes
commented
Mar 15, 2019
| @@ -294,6 +294,53 @@ Cryptographic Hashing | |||
| >>> Web3.solidityKeccak(['address'], ["ethereumfoundation.eth"]) | |||
| HexBytes("0x913c99ea930c78868f1535d34cd705ab85929b2eaaf70fcd09677ecd6e5d75e9") | |||
|
|
|||
| .. py:classmethod:: Web3.sha3(primitive=None, hexstr=None, text=None) | |||
There was a problem hiding this comment.
I added these back in because I noticed they haven't gone through a deprecation cycle. They were deprecated in v5a1.
pipermerriam
approved these changes
Mar 18, 2019
docs/index.rst
Outdated
| @@ -15,7 +15,7 @@ Contents | |||
| quickstart | |||
| overview | |||
| node | |||
| v4_migration | |||
There was a problem hiding this comment.
hrm, since v4 is still supported should we keep the v4_migration docs?
There was a problem hiding this comment.
ohh right. Ya, good idea
docs/v5_migration.rst
Outdated
|
|
||
| In v4, JSON-RPC calls that looked up transactions or blocks and | ||
| didn't find them, returned ``None``. Now if a transaction or | ||
| block is not found, an error will be thrown. This applies to |
There was a problem hiding this comment.
Probably good to indicate the exception class that will be raised.
docs/v5_migration.rst
Outdated
| - ``contract.call`` was removed for ``contract.<functions/events>.<method name>.call`` | ||
| - ``contract.transact`` was removed for ``contract.<functions/events>.<method name>.transact`` | ||
| - ``contract.eventFilter`` was removed for ``contract.events.<event name>.createFilter`` | ||
| - ``middleware_stack`` was removed for :meth:`~Web3.middleware_onion` |
There was a problem hiding this comment.
Maybe s/removed for/renamed to
carver
approved these changes
Mar 18, 2019
| - ``web3.providers.tester.EthereumTesterProvider`` and ``web3.providers.tester.TestRPCProvider`` have been removed for :meth:`~web3.providers.eth_tester.EthereumTesterProvider` | ||
|
|
||
| Deprecated Methods | ||
| ~~~~~~~~~~~~~~~~~~ |
There was a problem hiding this comment.
Maybe something like: "expect these to be removed in v6".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
As we are nearing the beta release of v5, a migration guide needed to be added so people know how to migrate.
Related to Issue #1260
How was it fixed?
Added one!
Cute Animal Picture