Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move admin module to geth namespace #1288

Merged
merged 1 commit into from
Mar 19, 2019
Merged

Move admin module to geth namespace #1288

merged 1 commit into from
Mar 19, 2019

Conversation

njgheorghita
Copy link
Contributor

@njgheorghita njgheorghita commented Mar 18, 2019 •
edited
Loading

What was wrong?

Related to Issue #1273

How was it fixed?

Moved web3.admin module to web3.geth namespace

Cute Animal Picture

image

@njgheorghita njgheorghita force-pushed the relocate-admin-module branch 4 times, most recently from 9094f36 to eac62aa Compare March 18, 2019 10:54
kclowes
kclowes approved these changes Mar 18, 2019
View reviewed changes
Copy link
Collaborator

@kclowes kclowes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@njgheorghita njgheorghita merged commit 4acfb9d into ethereum:master Mar 19, 2019
@njgheorghita njgheorghita deleted the relocate-admin-module branch March 19, 2019 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kclowes kclowes kclowes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@njgheorghita @kclowes