1193 bugfix: don't silently ignore constructor args when no constructor function is provided #1316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pipermerriam
reviewed
Apr 8, 2019
redshiftzero
force-pushed
the
1193-missing-abi-constructor
branch
from
80022c8
to
ec45218
Compare
|
Thank you @redshiftzero! If you pull in the latest master, those failures should go away |
redshiftzero
force-pushed
the
1193-missing-abi-constructor
branch
from
ec45218
to
1591c20
Compare
|
thanks @kclowes @pipermerriam, this should be ready for re-review |
|
Looks good to me! @pipermerriam do you have any other feedback? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
Fix bug #1193 (constructor arguments are passed and silently ignored when no constructor function is provided)
How was it fixed?
Raise exception as suggested in the ticket
Cute Animal Picture