Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace web3._utils.toolz imports #1317

Merged
merged 1 commit into from
May 13, 2019
Merged

Replace web3._utils.toolz imports #1317

merged 1 commit into from
May 13, 2019

Conversation

jmcph4
Copy link
Contributor

@jmcph4 jmcph4 commented Apr 8, 2019

What was wrong?

Related to Issue #1196.

How was it fixed?

Basic text search-and-replace, via (From project root):

$ vim $(grep -r --include "*.py" "web3._utils.toolz" | cut -f1 -d :)

Then, iterate over each file, running the following substitution once in Vim:

%s/web3._utils.toolz/eth_utils.toolz/gI

Cute Animal Picture

Ragdoll cat

Copy link
Collaborator

@kclowes kclowes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking good! Thanks @jmcph4! We can go ahead and remove the web3/_utils/toolz directory as well since we're no longer using it.

@kclowes
Copy link
Collaborator

kclowes commented Apr 12, 2019

🎉 Thank you! As soon as the linting is fixed I'll merge!

web3/middleware/pythonic.py Outdated Show resolved Hide resolved
This commit replaces all `web3._utils.toolz` imports with
`eth_utils.toolz` imports via basic text substitution.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants