Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

testrpc isn't needed anymore #1322

Merged
merged 1 commit into from
Apr 10, 2019
Merged

testrpc isn't needed anymore #1322

merged 1 commit into from
Apr 10, 2019

Conversation

carver
Copy link
Collaborator

@carver carver commented Apr 10, 2019

What was wrong?

Just a bit of cleanup

How was it fixed?

Removed an unused extra.

Should be added to #722 so that it gets documented that the extra is gone (and any other references to the testrpc extra removed)

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

@carver carver requested a review from kclowes April 10, 2019 19:10
Copy link
Collaborator

@kclowes kclowes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💥 LGTM! Thanks @carver!

@carver carver merged commit f4a7d8c into master Apr 10, 2019
@carver carver deleted the remove-testrpc-extra branch April 10, 2019 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants