Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add note about web3[tester] in documentation. #1325

Merged
merged 1 commit into from
May 8, 2019

Conversation

relyt29
Copy link
Contributor

@relyt29 relyt29 commented Apr 12, 2019

What was wrong?

Related to Issue #1321- Carver pointed out where to add a note about the extras package for tester, so I added it to the RST

How was it fixed?

with vim, and about 20 seconds of my time.

Cute Animal Picture


  _--_                                     _--_
/#()# #\         0             0         /# #()#\
|()##  \#\_       \           /       _/#/  ##()|
|#()##-=###\_      \         /      _/###=-##()#|
 \#()#-=##  #\_     \       /     _/#  ##=-#()#/
  |#()#--==### \_    \     /    _/ ###==--#()#|
  |#()##--=#    #\_   \!!!/   _/#    #=--##()#|
   \#()##---===####\   O|O   /####===---##()#/
    |#()#____==#####\ / Y \ /#####==____#()#|
     \###______######|\/#\/|######______###/
        ()#O#/      ##\_#_/##      \#O#()
       ()#O#(__-===###/ _ \###===-__)#O#()
      ()#O#(   #  ###_(_|_)_###  #   )#O#()
      ()#O(---#__###/ (_|_) \###__#---)O#()
      ()#O#( / / ##/  (_|_)  \## \ \ )#O#()
      ()##O#\_/  #/   (_|_)   \#  \_/#O##()
       \)##OO#\ -)    (_|_)    (- /#OO##(/
        )//##OOO*|    / | \    |*OOO##\\(
        |/_####_/    ( /X\ )    \_####_\|
       /X/ \__/       \___/       \__/ \X\
      (#/                               \#)


Copy link
Collaborator

@kclowes kclowes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a minor grammar nitpick, but looks good otherwise! Thank you!

docs/providers.rst Outdated Show resolved Hide resolved
@relyt29 relyt29 force-pushed the web-tester-note-in-documentation branch from 6da833d to c235de0 Compare April 17, 2019 18:00
@relyt29
Copy link
Contributor Author

relyt29 commented Apr 17, 2019

Okay, made changes, thanks for the helpful hint on how to render the documentation locally - I think this should be good for another review

@kclowes kclowes merged commit a5d8c66 into ethereum:master May 8, 2019
@kclowes
Copy link
Collaborator

kclowes commented May 8, 2019

Sorry, I lost track of this. Looks good! Thank you!

@relyt29 relyt29 deleted the web-tester-note-in-documentation branch May 9, 2019 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants