[ethPM] Update Infura strategy #1383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
njgheorghita
force-pushed
the
ethpm-update-infura-strategy
branch
from
273f1a9
to
730a8f2
Compare
|
Assuming there is nothing special about that particular key, we could pull the API key from the environment. That would require that devs have it set locally, and then we would set the env variable in circle. If we do that, it's probably a good idea to add instructions to the README |
tests/ethpm/conftest.py
Outdated
| @pytest.fixture | ||
| def infura_env(monkeypatch): | ||
| # Please play nice and don't use this key for any shenanigans, thanks! | ||
| monkeypatch.setenv("WEB3_INFURA_PROJECT_ID", '4f1a358967c7474aae6f8f4a7698aefc') |
There was a problem hiding this comment.
I think I'm ok with this, at least as a temporary solution until we figure out a better approach. You could also use the environment variables and skip+warn when the variable isn't present.
njgheorghita
force-pushed
the
ethpm-update-infura-strategy
branch
14 times, most recently
from
e786a02
to
b272e8c
Compare
njgheorghita
force-pushed
the
ethpm-update-infura-strategy
branch
from
b272e8c
to
4fed555
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
ethpmhad its own strategy for connecting to infura via an api key set as an environment variable, which has been updated to useweb3's strategy. I'd like to get rid of hardcoding the api key, but since we rely on it for testing I'm not sure the best way to achieve that is / if it's even possible.Cute Animal Picture