Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ethPM] web3.pm management #1393

Merged
merged 3 commits into from
Jul 24, 2019
Merged

[ethPM] web3.pm management #1393

merged 3 commits into from
Jul 24, 2019

Conversation

njgheorghita
Copy link
Contributor

@njgheorghita njgheorghita commented Jul 18, 2019 •
edited
Loading

What was wrong?

If web3.pm is already enabled - trying to re-enable (via w3.enable_unstable_package_management_api) raises an error (cannot attach an attribute that's already been attached), this can cause problems when using web3.auto.infura.w3 but now it silently continues about its business.

Also..

Cute Animal Picture

image

@njgheorghita njgheorghita changed the title Web3 pm management [ethPM] web3.pm management Jul 18, 2019
@njgheorghita
Copy link
Contributor Author

merging since this is a minor cosmetic pr

@njgheorghita njgheorghita merged commit 8c12dc4 into ethereum:master Jul 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kclowes kclowes Awaiting requested review from kclowes

@pipermerriam pipermerriam Awaiting requested review from pipermerriam

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@njgheorghita