Eliminate signTransaction warning
#1404
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I found another module that uses the deprecated syntax. I believe this is all the usages that should change. There are more I found in search, but this only affects instances of |
|
Hehe, that picture. |
|
The one failed CircleCI task seems pretty unrelated to the functionality here? Not sure what the issue is. |
kclowes
approved these changes
Aug 1, 2019
Do you mind rebasing those two commits together? if you don't want to/don't have time I'm happy to do it, just let me know. Thank you!
|
I don't have the repo handy, I would appreciate it if you could handle that for me! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
I get the following warning when using this middleware:
It's annoying lol
How was it fixed?
Removed deprecated usage
Cute Animal Picture