Flag for Stricter ABI Type Checking #1419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kclowes
force-pushed
the
empty-str-flag
branch
4 times, most recently
from
602db5f
to
9096240
Compare
kclowes
force-pushed
the
empty-str-flag
branch
2 times, most recently
from
47089aa
to
4647b7d
Compare
kclowes
changed the title
kclowes
force-pushed
the
empty-str-flag
branch
from
6c9f050
to
b56de55
Compare
kclowes
force-pushed
the
empty-str-flag
branch
from
b56de55
to
264843f
Compare
kclowes
force-pushed
the
empty-str-flag
branch
from
264843f
to
0f26553
Compare
kclowes
changed the title
pipermerriam
reviewed
Sep 6, 2019
kclowes
force-pushed
the
empty-str-flag
branch
from
0ca91eb
to
042c934
Compare
kclowes
force-pushed
the
empty-str-flag
branch
from
6200fd0
to
f82a19d
Compare
kclowes
changed the title
|
@pipermerriam this is ready for another (and hopefully the last) round of real review |
pipermerriam
approved these changes
Sep 19, 2019
kclowes
force-pushed
the
empty-str-flag
branch
2 times, most recently
from
3bb9369
to
319dd33
Compare
kclowes
force-pushed
the
empty-str-flag
branch
from
319dd33
to
3b83926
Compare
This was referenced May 4, 2020
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
web3 v5 will accept a bytestring or a hexstring if a bytes value is specified in an ABI. Because an empty string can be decoded as hex, it wasn't raising a
ValidationErrorlike v4 did. It was also requested that we not allow bytes values that are shorter than the specified size.Related to issue #1412
How was it fixed
This PR adds a stricter type checking mechanism for bytes values that is available on the web3 instance. Using
w3.enable_strict_bytes_type_checking()will disallow strings that don't have a'0x', and will disallow byte strings that are different from the size the ABI specifies.I also noticed that we were using eth-abi's codec for events instead of the one registered in web3, so changed that over to use the codec on the web3 instance.
0xto an ABI with bytes specifiedCute animal picture
Todos: