address local_filter_middleware bug #1632
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wolovim
force-pushed
the
local-filter-middleware-bug
branch
from
01d1b2a
to
fa6da3a
Compare
pipermerriam
previously approved these changes
Apr 28, 2020
wolovim
force-pushed
the
local-filter-middleware-bug
branch
2 times, most recently
from
6853910
to
e5c6cc5
Compare
wolovim
force-pushed
the
local-filter-middleware-bug
branch
from
e5c6cc5
to
4aaaaf4
Compare
wolovim
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
FIlters are unable to parse for new log events with
local_filter_middlewareregistered. (Closes #1514)How was it fixed?
The
iter_latest_blockmethod in the middleware threw aStopIterationexception when the latest block was beyond theto_block. Devoid of context, this seems appropriate, but there seemed to be no advantage to this implementation practically. I updated this 'out of bounds' query to return None instead, which makes upstream methods happy without additional code changes. If this is egregiously unpythonic and another solution is recommended, let me know.Todo:
Cute Animal Picture