Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eth_call and eth_estimateGas use Method #1748

Merged
merged 3 commits into from
Sep 25, 2020

Conversation

kclowes
Copy link
Collaborator

@kclowes kclowes commented Sep 18, 2020

What was wrong/how was it fixed?

eth_call and eth_estimateGas now use the Method class.

Related to Issue #1585

Todo:

Cute Animal Picture

@kclowes kclowes changed the title [WIP] eth_call uses Method eth_call and eth_estimateGas use Method, add ENS name handling to sendTransaction Sep 21, 2020
@kclowes kclowes changed the title eth_call and eth_estimateGas use Method, add ENS name handling to sendTransaction [WIP] eth_call and eth_estimateGas use Method, add ENS name handling to sendTransaction Sep 21, 2020
@kclowes kclowes changed the title [WIP] eth_call and eth_estimateGas use Method, add ENS name handling to sendTransaction [WIP] eth_call and eth_estimateGas use Method Sep 24, 2020
@kclowes kclowes force-pushed the eth-to-method-6 branch 2 times, most recently from 53dc266 to c8197a0 Compare September 24, 2020 21:23
@kclowes kclowes changed the title [WIP] eth_call and eth_estimateGas use Method eth_call and eth_estimateGas use Method Sep 25, 2020
Copy link
Member

@wolovim wolovim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think revert msg is unblocked with this merge 🚀

@kclowes kclowes merged commit 0021510 into ethereum:master Sep 25, 2020
@kclowes kclowes deleted the eth-to-method-6 branch September 25, 2020 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants