Mark flaky ethpm test as flaky #1833
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kclowes
force-pushed
the
flaky-ethpm
branch
2 times, most recently
from
f2085ea
to
4bd37ed
Compare
kclowes
changed the title
wolovim
approved these changes
Jan 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
We have a test in the ethpm module that consistently runs into a timeout error during testing, especially when it gets run over and over again, like for small PR changes.
How was it fixed?
The PR pretty much speaks for itself, but added an xfail that specifies what error it's all right to fail with. If it fails with a different error, it will show up in the test output and fail the build.
Todo:
Cute Animal Picture