➕ Add Python 3.10 support

[wiseaidev]

Signed-off-by: Harmouch101 [email protected]

What was wrong?

Related to Issue #2172

How was it fixed?

Todo:

• Remove all commented out parity references
• Update websockets to 10.0 #2178
• Add entry to the release notes

Cute Animal Picture

🐶

[fselmo]

@Harmouch101 thanks for getting this started! I linked some issues that are relevant here, notably updating websockets version to 10.0

[wiseaidev]

I don't see black2b-py being mentioned in setup.py, so how this error is even possible:

ERROR: Could not find a version that satisfies the requirement blake2b-py<0.2,>=0.1.4 (from py-evm) (from versions: 0.1.2, 0.1.3)

Presumably, somehow another package in setup.py depends on it? is it py-evm?

[fselmo]

I don't see black2b-py being mentioned in setup.py, so how this error is even possible:

ERROR: Could not find a version that satisfies the requirement blake2b-py<0.2,>=0.1.4 (from py-evm) (from versions: 0.1.2, 0.1.3)

Presumably, somehow another package in setup.py depends on it? is it py-evm?

It is on py-evm. However, a new version of py-evm was just released where blake2b-py is an extra dependency and not always required. I'm actually working on getting eth-tester up to date so this can be updated in web3.py as well. It shouldn't have this issue after that.

[wiseaidev]

Yeah, I see.

[wiseaidev]

Someone take the wheel and spread some magic on this.

[akcelero]

@Harmouch101 not sure if it changes anything but in your CI config you is python:3.10.0rc2, although there is already final version 3.10.0

[wiseaidev]

@Harmouch101 not sure if it changes anything but in your CI config you is python:3.10.0rc2, although there is already final version 3.10.0

Going through the list of available python images on the official cicleci registry and on this github repo, i didn't find any stable release for python 3.10, I mean not alpha releases. That's the reason why I chose this variant of python 3.10. On the other hand, the version that you have mentioned is available not on the cicleci registry, but rather on a registry called cimg. Not sure if it is official or not. However, @fselmo already pushed a commit for this matter. But, I think the errors are not related to the python images being used.

[fselmo]

However, @fselmo already pushed a commit for this matter. But, I think the errors are not related to the python images being used.

Yeah sorry for the lack of context there... I pushed a commit just to check what the outcome would be with the cimg builds but it wasn't immediately obvious why it failed and I didn't have enough time to debug so I put things back for now. Haven't looked into the errors that came out of that too closely but it does look like they are official circleci "convenience" images. I wouldn't mind investigating that within this PR but only if it makes sense to. I should have more time to dive back in here soon.

[akcelero]

@Harmouch101 ok, I see, sorry and thanks for reply ; )

[ian-whitestone]

FYI i tried installing web3 on Python 3.10 for the first time today (not knowing what Python versions were supported) and got this error:

❯ python
Python 3.10.0 (default, Dec 19 2021, 22:01:54) [Clang 13.0.0 (clang-1300.0.29.30)] on darwin
Type "help", "copyright", "credits" or "license" for more information.
>>> import web3
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/Users/ianwhitestone/Library/Caches/pypoetry/virtualenvs/ethereum-etl-I6y7u93w-py3.10/lib/python3.10/site-packages/web3/__init__.py", line 7, in <module>
    from eth_account import Account  # noqa: E402
  File "/Users/ianwhitestone/Library/Caches/pypoetry/virtualenvs/ethereum-etl-I6y7u93w-py3.10/lib/python3.10/site-packages/eth_account/__init__.py", line 1, in <module>
    from eth_account.account import Account  # noqa: F401
  File "/Users/ianwhitestone/Library/Caches/pypoetry/virtualenvs/ethereum-etl-I6y7u93w-py3.10/lib/python3.10/site-packages/eth_account/account.py", line 1, in <module>
    from collections import (
ImportError: cannot import name 'Mapping' from 'collections' (/Users/ianwhitestone/.pyenv/versions/3.10.0/lib/python3.10/collections/__init__.py)

[LeaveMyYard]

FYI i tried installing web3 on Python 3.10 for the first time today (not knowing what Python versions were supported) and got this error:

❯ python
Python 3.10.0 (default, Dec 19 2021, 22:01:54) [Clang 13.0.0 (clang-1300.0.29.30)] on darwin
Type "help", "copyright", "credits" or "license" for more information.
>>> import web3
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/Users/ianwhitestone/Library/Caches/pypoetry/virtualenvs/ethereum-etl-I6y7u93w-py3.10/lib/python3.10/site-packages/web3/__init__.py", line 7, in <module>
    from eth_account import Account  # noqa: E402
  File "/Users/ianwhitestone/Library/Caches/pypoetry/virtualenvs/ethereum-etl-I6y7u93w-py3.10/lib/python3.10/site-packages/eth_account/__init__.py", line 1, in <module>
    from eth_account.account import Account  # noqa: F401
  File "/Users/ianwhitestone/Library/Caches/pypoetry/virtualenvs/ethereum-etl-I6y7u93w-py3.10/lib/python3.10/site-packages/eth_account/account.py", line 1, in <module>
    from collections import (
ImportError: cannot import name 'Mapping' from 'collections' (/Users/ianwhitestone/.pyenv/versions/3.10.0/lib/python3.10/collections/__init__.py)

As a temporary fix you can try some monkey patch like this:

import collections
from collections.abc import Mapping, MutableMapping, Sequence, Iterable, Hashable, Generator


for patch_item in [Mapping, MutableMapping, Sequence, Iterable, Hashable, Generator]:
    setattr(collections, patch_item.__name__, patch_item)

At least it fixes an ImportError

[kclowes]

@pacrob or @fselmo - do one of you mind taking another look? Thanks for getting this going @Harmouch101!

[fselmo]

Just a couple of the circleci jobs are on the config twice but otherwise this looks good to me! Thanks @Harmouch101 and thanks @kclowes 👍 🎉

[fselmo]

looks like py310-integration-ethtester-pyevm and py310-wheel-cli are on here twice