Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Peripheral London updates: #2205

Merged
merged 1 commit into from
Nov 15, 2021

Conversation

fselmo
Copy link
Collaborator

@fselmo fselmo commented Nov 12, 2021

What was wrong?

Peripheral London updates across the library.

How was it fixed?

  • Updated contract buildTransaction() to default to dynamic fee transactions.
  • Updated core tests to use dynamic fee transactions by default.
  • Add default values for maxFeePerGas and maxPriorityFeePerGas for fill_transaction_defaults() when no gas price strategy is set and no gasPrice value is present (legacy transaction).

Todo:

Cute Animal Picture

IMG_20211019_095131

@fselmo fselmo force-pushed the update-core-tests-to-use-1559-params branch 7 times, most recently from bcb76ca to dc1dfaf Compare November 15, 2021 17:07
- update `buildTransaction()` to default to dynamic fee transaction params
- add default values for dynamic fee transaction params
- update core tests to use dynamic fee transactions by default where appropriate
@fselmo fselmo force-pushed the update-core-tests-to-use-1559-params branch from dc1dfaf to 367b532 Compare November 15, 2021 18:26
Copy link
Collaborator

@kclowes kclowes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@fselmo fselmo merged commit 34f91a3 into ethereum:master Nov 15, 2021
@fselmo fselmo deleted the update-core-tests-to-use-1559-params branch November 15, 2021 18:41
@fselmo fselmo mentioned this pull request Dec 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants