Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Abi _utils to utils #2596

Merged
merged 2 commits into from
Aug 8, 2022
Merged

Abi _utils to utils #2596

merged 2 commits into from
Aug 8, 2022

Conversation

fselmo
Copy link
Collaborator

@fselmo fselmo commented Aug 5, 2022

What was wrong?

Cherry picked from PR #2496. Couldn't push to that branch and that PR went stale, so opened up a new one.

How was it fixed?

  • Moved the requested internal API utility methods over to the public utility API module. This can serve as a starting point for other useful ABI utility methods to be moved over eventually as well.

Todo:

Cute Animal Picture

baby stingrays
Put a link to a cute animal picture inside the parenthesis-->

@fselmo fselmo changed the title Abi utils to utils Abi _utils to utils Aug 5, 2022
@fselmo fselmo requested review from pacrob and kclowes August 5, 2022 21:17
@fselmo fselmo marked this pull request as ready for review August 5, 2022 21:17
- Move some abi utility methods from the internal utility module to the public ``web3.utils`` module.
Copy link
Collaborator

@kclowes kclowes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! :shipit:

@fselmo fselmo merged commit 41f88cb into ethereum:master Aug 8, 2022
@fselmo fselmo deleted the abi-_utils-to-utils branch April 3, 2024 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants