Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove docs reference to removed eth-account recoverHash method #2615

Merged
merged 1 commit into from
Aug 24, 2022

Conversation

pacrob
Copy link
Contributor

@pacrob pacrob commented Aug 22, 2022

What was wrong?

Deprecated eth-account methods are being removed. This removes a reference to the recoverHash method that is among them.

Related to ethereum/eth-account#195

How was it fixed?

Deleted related docs section

Todo:

Cute Animal Picture

image

@pacrob pacrob force-pushed the deprecated-eth-account-methods branch from 845397a to d55b11a Compare August 22, 2022 20:18
@pacrob pacrob requested a review from kclowes August 22, 2022 20:26
Copy link
Collaborator

@kclowes kclowes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@pacrob pacrob merged commit b8d9177 into ethereum:master Aug 24, 2022
pacrob pushed a commit to pacrob/web3.py that referenced this pull request Sep 8, 2022
@ChristianPapathanasiou
Copy link

What was recoverHash replaced with? Ugpraded library, everything is breaking now.

@pacrob
Copy link
Contributor Author

pacrob commented Mar 22, 2024

What was recoverHash replaced with? Ugpraded library, everything is breaking now.

The removal in eth-account was done here: https://github.com/ethereum/eth-account/pull/195/files

Looks like recover_message is the replacement. I should work similarly, but requires a SignableMessage instead of just a string.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants