Renaming leftover references to deprecated eth_abi.decode_abi to eth_abi.decode
#2636
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Woo, thanks for catching those! Not sure why I missed them. I'll read it over and look at those test timeouts, but looks good so far. |
|
@pacrob the timeouts are unrelated to this PR. I'm going to do some digging in. We think it may be from the new geth fixture. |
pacrob
pushed a commit
that referenced
this pull request
Sep 8, 2022
…th_abi.decode` (#2636) * Renaming leftover references to deprecated `eth_abi.decode_abi` to `eth_abi.decode`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
eth_abi.decode_abiwas renamed toeth_abi.decodeand the original method was deprecated. #2626 already addressed the calls toeth_abi.encode_abiRelated to Issue #2621
How was it fixed?
Replaced all instances of
eth_abi.decode_abiwitheth_abi.decodeTodo:
Cute Animal Picture