Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

find missing readthedocs bulletpoints #2688

Merged
merged 4 commits into from
Oct 24, 2022

Conversation

pacrob
Copy link
Contributor

@pacrob pacrob commented Oct 20, 2022

What was wrong?

Unordered list bulletpoints were missing in RTD.

How was it fixed?

A CSS fix was issued in sphinx_rtd_theme v0.5.2. Bumped our version.

Also:

  • Removed unneeded sphinx-better-theme docs dependency
  • Moved notation of requirements-docs.txt as build deps for RTD from their dashboard into .readthedocs.yml

Todo:

Cute Animal Picture

image

@pacrob pacrob force-pushed the readthedocs-bullets branch 10 times, most recently from 9d8c99c to a5ab538 Compare October 24, 2022 19:36
Copy link
Collaborator

@kclowes kclowes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thanks for fixing this! Much better.

@pacrob pacrob merged commit af3a750 into ethereum:master Oct 24, 2022
@pacrob pacrob deleted the readthedocs-bullets branch October 24, 2022 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants