Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove parity namespace and refs #2718

Merged
merged 1 commit into from
Nov 16, 2022
Merged

Conversation

wolovim
Copy link
Member

@wolovim wolovim commented Nov 16, 2022

What was wrong?

  • Parity has long been sunset. The namespace within web3.py doesn't need maintaining.
  • Node-related docs have gotten nice and stale in a few locations. Removed some stated preferences and replaced links with ethereum.org so they can maintain lists of tools over time.

(Note: we didn't rush into ripping this functionality out given feedback at various points that some users still used tracing features via OpenEthereum or modded Parity nodes. If you are negatively impacted by this code removal, you can use custom methods or external modules to introduce non-standard features.)

v6 breaking change related to: #1416

Todo:

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

Copy link
Contributor

@pacrob pacrob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

Copy link
Collaborator

@kclowes kclowes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 !

@wolovim wolovim merged commit ff3e023 into ethereum:master Nov 16, 2022
@wolovim wolovim deleted the remove-parity branch November 16, 2022 22:20
@wolovim wolovim mentioned this pull request Nov 16, 2022
22 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants