Async name to address #2758
Closed
Async name to address #2758
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Pull in the async curry method from the ``paco`` library, which seems to no longer be maintained. Refactor to remove deprecated ``asyncio.coroutine()`` calls. Introduce typing to those methods. Add the tests for the curry method and refactor. - Rename to ``async_curry`` and add a note to use ``functools.curry`` for non-async methods.
fselmo
force-pushed
the
async-name-to-address
branch
from
842d45d
to
da49aff
Compare
pacrob
force-pushed
the
async-name-to-address
branch
from
0cd554c
to
f1602b5
Compare
pacrob
force-pushed
the
async-name-to-address
branch
from
f1602b5
to
1a947bf
Compare
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
closes #2583
closes #1990
How was it fixed?
paco-inspired methods for async curry support and refactor code, removing deprecatedasyncio.coroutinein place ofasync def+awaitusage.pacolibrary for the newasync_currymethod.web3._utils.async_functools.pyname_to_address_middlewareTodo:
Cute Animal Picture