Bump pytest to version 7

[e3243eric]

What was wrong?

Related to Issue #2859. From CI warning: DeprecationWarning: You're using an outdated version of pytest. Newer releases of pytest-asyncio will not be compatible with this pytest version. Please update pytest to version 7 or later.

How was it fixed?

Bump pytest to version 7.

Todo:

• Add entry to the release notes

Cute Animal Picture

[e3243eric]

The plugin pytest-pythonpath is obsolete after pytest 7.0.0. Now pytest using the pythonpath configuration option.

[e3243eric]

The test_eth_get_balance_with_block_identifier failed because the block was not mined to block 1. This is because the test execution order has been changed by pytest. test_eth_get_balance_with_block_identifier was executed before some tests which mining blocks. (like test_eth_get_storage_at will mine a block because of the emitter_contract_deploy_txn_hash fixture)

Should I mine a new block by the block_with_txn fixture in test_eth_get_balance_with_block_identifier? Overwrite test_eth_get_balance_with_block_identifier in the TestEthereumTesterEthModule class? Or any other suggestions?

[fselmo]

Should I mine a new block by the block_with_txn fixture in test_eth_get_balance_with_block_identifier? Overwrite test_eth_get_balance_with_block_identifier in the TestEthereumTesterEthModule class? Or any other suggestions?

I'd rather address it in the TestEthereumTesterEthModule since the dynamics can be a bit different across providers. This would explicitly target the EthereumTesterProvider. There are different ways to do it I suppose but one of the most explicit ways may be to do something like:

    def test_eth_get_balance_with_block_identifier(self, w3: "Web3") -> None:
        # send some money to the coinbase account to ensure later balance > genesis
        w3.eth.send_transaction({"to": w3.eth.coinbase, "value": 1, "gas": 21000})

        super().test_eth_get_balance_with_block_identifier(w3)

thoughts?

[e3243eric]

Thanks for @fselmo! Your suggestion is great and clear. I push the same commit here. But I have a dumb question, why did you choose to send some value to the coinbase address? If any transaction is sent (same as block mined in EthereumTesterProvider), like sent to another address or sent with zero value, will the block reward to the coinbase address?

[fselmo]

will the block reward to the coinbase address?

Frankly, I don't remember off the top of my head if the eth-tester + py-evm combo handles the reward appropriately (it should) 😅. If it works to just mine a block then that's great too 🙂

[e3243eric]

I think it does. The test works until the execution order changes.

Since it is to test get_balance with a block number, I think sending a transaction to the coinbase address is a good idea, no matter where the block reward goes. I was curious about the block reward. 🙂
PR is ready for review.

[fselmo]

Yeah it should handle all of that appropriately but the value transfer is more explicit 👍🏼

[e3243eric]

I saw the PR #2887 dealing with pythonpath and test_eth_get_balance_with_block_identifier, so I only bumped Pytest here.

[kclowes]

Thanks for the contribution @e3243eric! I left a few comments that I can get to in the next few days if you aren't able/willing.

[kclowes]

Since this is a dev dependency change, let's call this filename newsfragments/2863.internal.rst

[kclowes]

If possible, I'd rather bump pytest>=7.0.0 to allow a wider range. Does that work here?

[e3243eric]

Thanks for all the reviews.

[kclowes]

Thanks @e3243eric! Looks good to me!