Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use the correct type for trace_filter #2913

Merged
merged 3 commits into from
Apr 12, 2023
Merged

Use the correct type for trace_filter #2913

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8340ce4
Use the correct type for `trace_filter`
Uxio0 Apr 12, 2023
44cd544
Trigger CI
kclowes Apr 12, 2023
55afb72
Add newsfragment, fix lint
kclowes Apr 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions newsfragments/2913.bugfix.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Use ``TraceFilterParams`` instead of ``FilterParams`` for ``trace_filter`` typing
4 changes: 2 additions & 2 deletions web3/tracing.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,8 +29,8 @@
from web3.types import (
BlockIdentifier,
BlockTrace,
FilterParams,
FilterTrace,
TraceFilterParams,
TraceMode,
TxParams,
_Hash32,
Expand Down Expand Up @@ -73,7 +73,7 @@ def trace_replay_transaction_munger(
mungers=[default_root_munger],
)

trace_filter: Method[Callable[[FilterParams], List[FilterTrace]]] = Method(
trace_filter: Method[Callable[[TraceFilterParams], List[FilterTrace]]] = Method(
RPC.trace_filter,
mungers=[default_root_munger],
)
Expand Down