Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update pyproject.toml to current template format #2959

Merged
merged 1 commit into from
May 15, 2023

Conversation

pacrob
Copy link
Contributor

@pacrob pacrob commented May 15, 2023

What was wrong?

When deprecating ethPM, I added deprecation to the valid newsfragment types in the newsfragments folder but not in `pyproject.toml'.

Related to Issue #2953

How was it fixed?

Set pyproject.toml to match the current template version, which includes deprecation. This required updating the newsfragment type doc to docs in a few places too.

Todo:

Cute Animal Picture

image

@pacrob pacrob force-pushed the update-towncrier-in-pyprojecttoml branch 2 times, most recently from 136a245 to a7c3d39 Compare May 15, 2023 19:46
@pacrob pacrob requested review from fselmo and kclowes and removed request for fselmo May 15, 2023 19:47
Copy link
Collaborator

@kclowes kclowes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a nit, but LGTM other than that once tests are passing!

pyproject.toml Outdated Show resolved Hide resolved
@pacrob pacrob force-pushed the update-towncrier-in-pyprojecttoml branch from a7c3d39 to 1a816b8 Compare May 15, 2023 19:54
Copy link
Collaborator

@fselmo fselmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, lgtm after nit fix!

pyproject.toml Outdated Show resolved Hide resolved
@pacrob pacrob force-pushed the update-towncrier-in-pyprojecttoml branch from 1a816b8 to b06d3f4 Compare May 15, 2023 20:11
@pacrob pacrob merged commit 94b5c8d into ethereum:main May 15, 2023
@pacrob pacrob deleted the update-towncrier-in-pyprojecttoml branch May 15, 2023 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants