Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update async http docs #3070

Merged
merged 4 commits into from
Aug 2, 2023
Merged

Conversation

kclowes
Copy link
Collaborator

@kclowes kclowes commented Aug 2, 2023

What was wrong?

  • The AsyncHTTPProvider docs still said that you couldn't use the ENS middleware, but you can.
  • Also removed the data key from the Eth-tester RPCError response to standardize with other clients.

How was it fixed?

Updated docs, and eth-tester error response.

Todo:

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

@kclowes kclowes marked this pull request as ready for review August 2, 2023 17:18
docs/providers.rst Outdated Show resolved Hide resolved
Copy link
Collaborator

@fselmo fselmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍🏼 I think we can remove the "exceptions" when comparing to sync HTTPProvider but other than that ship it 🚢

@kclowes kclowes merged commit 7ad4e65 into ethereum:main Aug 2, 2023
1 check passed
@kclowes kclowes deleted the update-async-http-docs branch August 2, 2023 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants