Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove all sys.version_info checks, presuming Python 3.5+ #455

Closed
wants to merge 4 commits into from
Closed

Remove all sys.version_info checks, presuming Python 3.5+ #455

wants to merge 4 commits into from

Conversation

miguel550
Copy link
Contributor

What was wrong?

It have python 2 and python 3.3 checks all over the places.

How was it fixed?

I remove them carefully.

Cute Animal Picture

Cute animal picture

@carver
Copy link
Collaborator

carver commented Nov 22, 2017

I'm not sure how you accomplished this, but this commit seems to be removing and re-adding every file? Maybe it's changing the newlines from \n to \r\n? The diff doesn't make any sense to me.

@miguel550
Copy link
Contributor Author

I'll check that right now.

@miguel550
Copy link
Contributor Author

After investigating it seems like Windows is changing all the files' permissions to 777 and github is taking it as a change. It does not seems like a problem but if it is I can make the changes again in a clean way.

More info: microsoft/WSL#184

@carver
Copy link
Collaborator

carver commented Nov 22, 2017

@miguel550 yes, this definitely needs to be fixed. It is impossible to code review this way. Try again after the suggestion from the thread you linked:

# For the current repository
git config core.filemode false   

# Globally
git config --global core.filemode false

(force pushing the re-issued commits to your branch is fine here)

@miguel550 miguel550 closed this Nov 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants