Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove xfail for newBlockFilter parity integration test #992

Merged
merged 1 commit into from
Aug 7, 2018
Merged

Remove xfail for newBlockFilter parity integration test #992

merged 1 commit into from
Aug 7, 2018

Conversation

dylanjw
Copy link
Contributor

@dylanjw dylanjw commented Aug 6, 2018

What was wrong?

Related to Issue #671

Cute Animal Picture

image

@dylanjw dylanjw changed the title Remove xfail for newBlock filter test Remove xfail for newBlockFilter parity integration test Aug 6, 2018
@dylanjw
Copy link
Contributor Author

dylanjw commented Aug 6, 2018

...wondering why xfail_strict=true in our pytest.ini file didn't cause the XPASS to be marked as a fail before.

@carver
Copy link
Collaborator

carver commented Aug 7, 2018

...wondering why xfail_strict=true in our pytest.ini file didn't cause the XPASS to be marked as a fail before.

Hmm, that seems like a good thing to investigate.

@dylanjw dylanjw merged commit 9c2e4e8 into ethereum:master Aug 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carver carver carver approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dylanjw @carver