This repository has been archived by the owner on Apr 6, 2020. It is now read-only.
Fix address format in genesis files #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
why is genesis states a different file? |
|
For performance/memory reasons. We don't want to take on the load to always have to load especially the huge genesis state from mainnet if a library is just interested in some common genesis parameters. That's exactly the kind of stuff I would like to have some discussion around and contribute with our needs on the genesis format EIP discussion. |
|
I see. I will have to catch up with this discussion. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Consistent prefix of all genesis address values with
0x.