This repository has been archived by the owner on Apr 6, 2020. It is now read-only.
genesis: Makes account balances format consistent across networks #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evertonfraga
changed the title
|
mind note: I should add conformance tests to ensure new files adhere to hex. |
holgerd77
approved these changes
Nov 11, 2019
| @@ -3,5 +3,5 @@ | |||
| "0x0000000000000000000000000000000000000002": "0x1", | |||
| "0x0000000000000000000000000000000000000003": "0x1", | |||
| "0x0000000000000000000000000000000000000004": "0x1", | |||
| "0x00521965e7bd230323c423d96c657db5b79d099f": "1606938044258990275541962092341162602522202993782792835301376" | |||
| "0x00521965e7bd230323c423d96c657db5b79d099f": "0x100000000000000000000000000000000000000000000000000" | |||
| } | |||
There was a problem hiding this comment.
mainnet file comment (no way to attach found due to file size):
Consistency checks, addition/deletion number stays the same, random value tests (full text searches), genesis block hash test execution from Everton.
Looks good.
| "0x00000000000000000000000000000000000000fd": "0x0", | ||
| "0x00000000000000000000000000000000000000fe": "0x0", | ||
| "0x00000000000000000000000000000000000000ff": "0x0", | ||
| "0x874b54a8bd152966d63f706bae1ffeb0411921e5": "0xc9f2c9cd04674edea40000000" | ||
| } |
There was a problem hiding this comment.
Ok, number of "1" -> "0x1" balances stayed the same, single more funded account moved to bottom.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR converts all balances from decimal to hex. Ordering shouldn't matter and the diff got rather impossible to review manually — but the tests cover that.
I put this gist up for whoever wants to audit the process of data gathering and transformation. It was fun learning to use jq to manipulate json content 😄
To test:
npm run distethereumjs-vm/node_modules/ethereumjs-commonnpm run build:dist && tape './tests/api/state/stateManager.js'This test ensures genesis block hash matches state root for each chain (example).
Related: ethereumjs/ethereumjs-monorepo#589
Closes #35.