-
Notifications
You must be signed in to change notification settings - Fork 759
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EIP-6110: Supply Validator Deposits on Chain #3303
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more. |
…to eip-6110-implementation
…to eip-6110-implementation
…g prague, for now
…to eip-6110-implementation
…to eip-6110-implementation
…eumjs-monorepo into eip-6110-implementation
I've pointed #3336 towards this branch :) Before we merge this one into |
Ugh. Now having read this EIP for the first time I’m realizing what a complex beast this is, always considered this more as some „side EIP“. 🤯 @scorbajio Congrats on that, this looks already pretty great! 🤩 Really blown away by the amount of code already touched here! |
…to eip-6110-implementation
TransactionsBytes, | ||
UncleHeadersBytes, | ||
WithdrawalsBytes, | ||
DepositsBytes, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if this is going to be before or after ExecutionWitnessBytes
in Prague.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ExecutionWitness is for Verkle which is not scheduled for Prague, so Deposits can always be placed before ExecutionWitness.
…n + mainnet in failing 6110 block test
comment: 'Supply validator deposits on chain', | ||
url: 'https://eips.ethereum.org/EIPS/eip-6110', | ||
status: Status.Draft, | ||
minimumHardfork: Hardfork.Cancun, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The minimumHardfork
is not the inclusion HF, but the first HF from which this EIP can be run in isolation (so: all pre-requisits for the EIP are met). So we can (should) switch to Cancun
here, just as some additional context.
Implementation of EIP-6110 is being continued at #3390. |
This PR implements EIP-6110 and addresses issue #3299.