Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement EIP 7002 (withdrawal requests) #3385
Implement EIP 7002 (withdrawal requests) #3385
Changes from 11 commits
640290f
1a7145a
a7f78ee
2a7b755
8e67d22
1235c60
ef00da0
b58d6be
b48edf1
29f64cb
765c804
6dbb5f2
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we name this a bit more verbose, I would suggest
withdrawalRequestContractAddress
?For
withdrawalsAddress
imagination can go in various - and sometimes wrong - directions what this could mean (address for sending the withdrawals towards e.g.).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we document the single steps a bit more, so that the whole code gets a bit easier reproduceable/understandable if one is not so deep into the EIP (any more)? 🙂
So this call basically triggers this part from the EIP, right? (respectively, in more practical terms: trigger withdrawal request contract code execution doing these things as described)
So it would be nice if we have some summary docs here like (to be freely adopted):
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here: rename would be nice.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a fantastic test. I didn't even think about being able catch the generated block from teh
afterBlock
event.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, actually I want to raise a point about this, isn't the entire point of
generate
to actually retrieve the generated block (i.e. build the block?). I was somewhat surprised that this block was not returned fromrunBlock
so had to figure out if I would be able to extract it (if that was even possible). So this is something we could take a look at in the future (not part of this PR)