Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

util: revert some PrefixedHexString breaking changes #3427

Merged
merged 8 commits into from
May 14, 2024

Conversation

gabrocheleau
Copy link
Contributor

@gabrocheleau gabrocheleau commented May 14, 2024

This PR re-adds support for type string as an input type for some util helpers, to preserve backwards compatibility.

I also realized that isHexPrefixed was redundant (we already had an internal helper that implements that behavior) so I removed it.

@gabrocheleau gabrocheleau marked this pull request as ready for review May 14, 2024 19:06
Copy link
Contributor

@scorbajio scorbajio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Left a few suggestions and comments.

packages/util/README.md Outdated Show resolved Hide resolved
packages/util/src/internal.ts Outdated Show resolved Hide resolved
packages/util/src/internal.ts Show resolved Hide resolved
Copy link

codecov bot commented May 14, 2024

Codecov Report

Attention: Patch coverage is 11.11111% with 8 lines in your changes are missing coverage. Please review.

Project coverage is 80.92%. Comparing base (d24ca11) to head (de9a61b).
Report is 13 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

Flag Coverage Δ
blockchain 90.97% <ø> (ø)
common ?
evm 73.76% <ø> (?)
genesis 99.98% <ø> (?)
statemanager ?
trie 59.42% <20.00%> (?)
util ?
vm 63.00% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Contributor

@scorbajio scorbajio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@scorbajio scorbajio merged commit bc648e7 into master May 14, 2024
33 of 36 checks passed
@scorbajio scorbajio deleted the util/revert-hex-to-bytes branch May 14, 2024 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants