Add runBlock API tests #360
Conversation
| if (!opts.block) { | ||
| return cb(new Error('invalid input, block must be provided')) | ||
| } | ||
|
|
| populateCache: stateManager.warmCache.bind(stateManager), | ||
| runTx: (opts, cb) => cb(new Error('test')), | ||
| runCall: (opts, cb) => cb(new Error('test')), | ||
| _common: new Common('mainnet', 'byzantium') |
There was a problem hiding this comment.
Good that you instantiate explicitly with Byzantium here, so that we know the test data used is created in a Byzantium HF context.
| @@ -0,0 +1,121 @@ | |||
| { | |||
| "blocks" : [ | |||
There was a problem hiding this comment.
Can you add a "comment" field (shouldn't break anything, should it?) or similar here with a note, where you are taking the test data from (I assume from ethereum/tests together with a date and HF note?
| .catch((e) => st.ok(e.message.includes('invalid input'), 'correct error')) | ||
|
|
||
| st.end() | ||
| }) |
| .catch((e) => st.ok(e.message.includes('invalid input'), 'correct error')) | ||
|
|
||
| st.end() | ||
| }) |
| .then(() => t.fail('should have returned error')) | ||
| .catch((e) => t.equal(e.message, 'test')) | ||
|
|
||
| st.end() |
There was a problem hiding this comment.
Not seeing this instantaneously, why is runTx failing here? Maybe this is more obvious then I get right now, but eventually make it a bit more explicit (by variable naming or comment adding) anyhow.
There was a problem hiding this comment.
Sorry it wasn't very clear, because the suite setup is happening at the beginning of the file. Here and in the other test case runTx and runCall are failing because I've replaced them with a mock that simply calls the callback with an error.
I added comments to explain this in the source file as well.
| .catch((e) => t.ok(e.message.includes('higher gas limit'))) | ||
|
|
||
| t.end() | ||
| }) |
| suite.vm.runTx = runTx | ||
| await suite.p.runBlock({ block, root: suite.vm.stateManager.trie.root }) | ||
| .then(() => t.fail('should have returned error')) | ||
| .catch((e) => t.equal(e.message, 'test')) |
There was a problem hiding this comment.
Again here, a bit more explicit stating why runCall fails so that others can easily grab would be nice.
| t.equal(res.results[0].gasUsed.toString('hex'), '5208', 'actual gas used should equal blockHeader gasUsed') | ||
|
|
||
| t.end() | ||
| }) |
Signed-off-by: Sina Mahmoodi <[email protected]>
s1na
force-pushed
the
test/api-runBlock
branch
from
827b1b0
to
3c33cff
Compare
This PR is part of the series for adding API test coverage. It:
runBlock.jslib/runBlock.jsto add two validation checks.