Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Monorepo: Fix platform-Specific Dependencies npm CLI Bug #3648

Merged
merged 3 commits into from
Sep 10, 2024

Conversation

holgerd77
Copy link
Member

This ports over a fix I have already applied on #3643 on maintenance-v8 fixing a bug for platform-specific dependencies not being included in a package-lock.json file, resulting in an...

Error: Cannot find module @rollup/rollup-darwin-arm64. npm has a bug related to optional dependencies (https://github.com/npm/cli/issues/4828). Please try `npm i` again after removing both package-lock.json and node_modules directory.

... error when running the npm run visualize:bundle command on Mac OS (+ potentially other linux machines?).

Fix is applied along this comment, the wider thread/issue directly deals with the core issue.

@holgerd77 holgerd77 force-pushed the fix-platform-specific-dependencies-npm-cli-bug branch from fd1e4a4 to 1efbb5b Compare September 10, 2024 09:51
Copy link

codecov bot commented Sep 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 43.27%. Comparing base (4470cc3) to head (a8f6fc8).
Report is 42 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

Flag Coverage Δ
block 70.13% <ø> (-3.32%) ⬇️
blockchain 89.28% <ø> (?)
client ?
common 91.36% <ø> (?)
devp2p 0.00% <ø> (?)
evm 68.68% <ø> (?)
genesis 0.00% <ø> (?)
statemanager 68.77% <ø> (?)
trie 54.47% <ø> (?)
tx ?
util 73.43% <ø> (?)
vm 61.64% <ø> (?)
wallet ?

Flags with carried forward coverage won't be shown. Click here to find out more.

@acolytec3 acolytec3 merged commit 41d4230 into master Sep 10, 2024
40 checks passed
@holgerd77 holgerd77 deleted the fix-platform-specific-dependencies-npm-cli-bug branch September 10, 2024 11:50
@ethereumjs ethereumjs deleted a comment from Maliksb11 Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants