Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various Verkle Fixes #3650

Merged
merged 59 commits into from
Sep 25, 2024
Merged

Various Verkle Fixes #3650

merged 59 commits into from
Sep 25, 2024

Conversation

acolytec3
Copy link
Contributor

@acolytec3 acolytec3 commented Sep 10, 2024

Fixes several bugs in our verkle trie implementation and adds a couple of tests from the python implementation to verify that basic interop is now possible.

Notable fixes

  • Correctly implement little-endian value construction in leaf nodes
  • Update leaf marker to little endian representation

Note: I'm not sure why most of these commits are showing up. Most of these are from a previous PR and the actual "files changed" section shows the true set of changes.

Copy link
Member

@holgerd77 holgerd77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@holgerd77 holgerd77 merged commit 15f8ff2 into master Sep 25, 2024
39 checks passed
@holgerd77 holgerd77 deleted the proofs-again branch September 25, 2024 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants