Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trie checkpoint test expansion #3705

Merged
merged 7 commits into from
Oct 1, 2024
Merged

Conversation

scorbajio
Copy link
Contributor

This change expands the trie package check-pointing tests, as suggested in #3701.

@scorbajio
Copy link
Contributor Author

I've started with porting over the statemanager account checkpointing test cases. No tests failed, but we could continue adding cases from there.

@holgerd77
Copy link
Member

That looks already super great 🤩, can you make delete the old cases in the file that are more double tested, so that we get to one aligned systematic and go out of this double structure? Optimally all old test cases go over!

Copy link
Member

@holgerd77 holgerd77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks a lot! 👍🙂🙏

@holgerd77 holgerd77 merged commit a40f4e6 into master Oct 1, 2024
39 checks passed
@holgerd77 holgerd77 deleted the trie-checkpoint-test-expansion branch October 1, 2024 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Trie: Better Structured & Expanded Checkpointing Tests
2 participants