Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update package-locks #838

Merged
merged 3 commits into from
Aug 21, 2020
Merged

Update package-locks #838

merged 3 commits into from
Aug 21, 2020

Conversation

ryanio
Copy link
Contributor

@ryanio ryanio commented Aug 19, 2020

CI is having trouble with some differing package-locks, so this PR should resolve.

I also resolved a hoisting warning by upgrading ethereumjs-testing in tx package to latest (1.3.3).

@codecov
Copy link

codecov bot commented Aug 19, 2020

Codecov Report

Merging #838 into master will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

Flag Coverage Δ
#account 92.85% <ø> (ø)
#block 77.81% <ø> (+0.22%) ⬆️
#blockchain 81.33% <ø> (+0.30%) ⬆️
#common 93.98% <ø> (-0.16%) ⬇️
#ethash 83.33% <ø> (ø)
#tx 94.16% <ø> (+0.13%) ⬆️
#vm 92.80% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Member

@holgerd77 holgerd77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@holgerd77 holgerd77 merged commit 59a4038 into master Aug 21, 2020
@holgerd77 holgerd77 deleted the update-package-locks branch August 21, 2020 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants