Skip to content
This repository has been archived by the owner on Apr 6, 2020. It is now read-only.

Fix #113 (signed FakeTransaction) #118

Merged
merged 1 commit into from
Jul 25, 2018
Merged

Conversation

ajhodges
Copy link
Contributor

Also serves as a contribution towards #114 .

This issue, discussed in #113, has a simple fix; a null check on the from setter. The bug is that if self._from is initialized to ethereumjs-util.toBuffer(null), it will contain a buffer object that represents '0'. Then if you call FakeTransaction.from, the getter will return that empty buffer object here (in getSenderAddress()):

if (this._from) {
  return this._from
}

This issue is currently preventing self-signed transactions from being submitted to ganache.

@coveralls
Copy link

coveralls commented Jul 24, 2018

Coverage Status

Coverage increased (+0.01%) to 98.795% when pulling 1fb1b74 on ShipChain:master into 32989a3 on ethereumjs:master.

Copy link
Member

@holgerd77 holgerd77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working this out, looks good. Also great that you added to the tests, this is very much needed.

@holgerd77 holgerd77 merged commit b569738 into ethereumjs:master Jul 25, 2018
@holgerd77
Copy link
Member

Released this as v1.3.7.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants