Skip to content
This repository has been archived by the owner on Apr 6, 2020. It is now read-only.

Simplify transaction's constructor and EIP155 handling #153

Merged
merged 10 commits into from
May 21, 2019
Merged

Simplify transaction's constructor and EIP155 handling #153

merged 10 commits into from
May 21, 2019

Commits on May 17, 2019

  1. Simplify EIP155 handling.

    @alcuadrado
    alcuadrado committed May 17, 2019
    Configuration menu
    Copy the full SHA
    37d43fc View commit details
    Browse the repository at this point in the history

  2. Update tests

    @alcuadrado
    alcuadrado committed May 17, 2019
    Configuration menu
    Copy the full SHA
    d0c7375 View commit details
    Browse the repository at this point in the history

Commits on May 18, 2019

  1. Validate v in its setter

    @alcuadrado
    alcuadrado committed May 18, 2019
    Configuration menu
    Copy the full SHA
    48e4f57 View commit details
    Browse the repository at this point in the history

  2. Fix bug when signing an already signed tx

    @alcuadrado
    alcuadrado committed May 18, 2019
    Configuration menu
    Copy the full SHA
    1159315 View commit details
    Browse the repository at this point in the history

Commits on May 19, 2019

  1. Remove outdated comment

    @alcuadrado
    alcuadrado committed May 19, 2019
    Configuration menu
    Copy the full SHA
    27b8876 View commit details
    Browse the repository at this point in the history

  2. Restore the Transaction's toJSON method

    @alcuadrado
    alcuadrado committed May 19, 2019
    Configuration menu
    Copy the full SHA
    7f08267 View commit details
    Browse the repository at this point in the history

  3. Remove any previous signature before signing again

    @alcuadrado
    alcuadrado committed May 19, 2019
    Configuration menu
    Copy the full SHA
    1698f75 View commit details
    Browse the repository at this point in the history

  4. Update fake's tests

    @alcuadrado
    alcuadrado committed May 19, 2019
    Configuration menu
    Copy the full SHA
    12f5de3 View commit details
    Browse the repository at this point in the history

  5. Add a tests for the new behaviour

    @alcuadrado
    alcuadrado committed May 19, 2019
    Configuration menu
    Copy the full SHA
    ed4b695 View commit details
    Browse the repository at this point in the history

Commits on May 21, 2019

  1. Add an explanation to an EIP155 test.

    @alcuadrado
    alcuadrado committed May 21, 2019
    Configuration menu
    Copy the full SHA
    bba15cb View commit details
    Browse the repository at this point in the history