Skip to content
This repository has been archived by the owner on Apr 6, 2020. It is now read-only.

bump version 1.3.3 -> 1.3.4 #83

Merged
merged 3 commits into from
Mar 7, 2018
Merged

bump version 1.3.3 -> 1.3.4 #83

merged 3 commits into from
Mar 7, 2018

Conversation

jwasinger
Copy link
Contributor

@jwasinger jwasinger commented Dec 22, 2017 •
edited
Loading

requires: #83

@coveralls
Copy link

Coverage Status

Coverage remained the same at 98.795% when pulling 425ff69 on bump-version-1.3.4 into 1caa1bb on master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 98.795% when pulling 425ff69 on bump-version-1.3.4 into 1caa1bb on master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 98.795% when pulling 835aecd on bump-version-1.3.4 into 1caa1bb on master.

@jwasinger jwasinger force-pushed the bump-version-1.3.4 branch 2 times, most recently from 425ff69 to d947968 Compare January 7, 2018 05:35
@coveralls
Copy link

Coverage Status

Coverage remained the same at 98.795% when pulling d947968 on bump-version-1.3.4 into 1caa1bb on master.

@holgerd77
Copy link
Member

Rebased. It is still desired to merge this?

@coveralls
Copy link

coveralls commented Jan 17, 2018 •
edited
Loading

Coverage Status

Coverage remained the same at 98.795% when pulling 7d2d7c7 on bump-version-1.3.4 into 80045d7 on master.

@coveralls
Copy link

coveralls commented Jan 17, 2018 •
edited
Loading

Coverage Status

Coverage remained the same at 98.795% when pulling 7d2d7c7 on bump-version-1.3.4 into 80045d7 on master.

holgerd77
holgerd77 previously approved these changes Jan 19, 2018
View reviewed changes
Copy link
Member

@holgerd77 holgerd77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, asked @kumavis to do an npm release after merge, not sure if he's available atm though.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 98.795% when pulling 47c8878 on bump-version-1.3.4 into 80045d7 on master.

@coveralls
Copy link

coveralls commented Jan 19, 2018 •
edited
Loading

Coverage Status

Coverage remained the same at 98.795% when pulling 71c7a65 on bump-version-1.3.4 into c444d18 on master.

holgerd77
holgerd77 approved these changes Mar 7, 2018
View reviewed changes
Copy link
Member

@holgerd77 holgerd77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now.

@holgerd77 holgerd77 merged commit b6a8975 into master Mar 7, 2018
@holgerd77 holgerd77 deleted the bump-version-1.3.4 branch March 7, 2018 09:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@holgerd77 holgerd77 holgerd77 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jwasinger @coveralls @holgerd77 @wanderer