Skip to content
This repository has been archived by the owner on Apr 6, 2020. It is now read-only.

Move from explicit es2015 to babel preset env #86

Merged
merged 1 commit into from
Mar 1, 2018

Conversation

pgebheim
Copy link

This is both the new fancy thing to do and ensures compatibility with node code that uses -env instead of explicit es201x.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 98.795% when pulling 3b7951c on use-babel-preset-env into 80045d7 on master.

@coveralls
Copy link

coveralls commented Jan 23, 2018

Coverage Status

Coverage remained the same at 98.795% when pulling 3c76baf on use-babel-preset-env into a393b60 on master.

holgerd77
holgerd77 previously approved these changes Jan 24, 2018
Copy link
Member

@holgerd77 holgerd77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

tinybike
tinybike previously approved these changes Feb 2, 2018
@tinybike
Copy link
Member

tinybike commented Feb 2, 2018

Looks good to me!

@tinybike
Copy link
Member

tinybike commented Feb 2, 2018

@wanderer if this looks okay to you, please merge + publish to npm when you get a chance 😄

@holgerd77 holgerd77 dismissed stale reviews from tinybike and themself via 3c76baf February 26, 2018 13:54
@holgerd77
Copy link
Member

Just rebased this.

Copy link
Member

@holgerd77 holgerd77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review again after rebase, looks good. Still. 😄

@tinybike
Copy link
Member

Is @wanderer still point man for this repo and for npm updates? Would be good to get this merged and pushed to npm!

@holgerd77
Copy link
Member

@tinybike I already asked Martin @wanderer some weeks ago, if npm publishing rights can be expanded to an active developer, e.g. @axic or me. Would you also be available for this? Will try to reach out to him again.

@holgerd77
Copy link
Member

@tinybike tried is the classic way, just sent an email. 😸

@tinybike
Copy link
Member

Sounds good! Yes, I'd be more than happy to help keep this repo up-to-date. My npm username is tinybike.

@axic
Copy link
Member

axic commented Feb 26, 2018

@holgerd77 since you understand babel way better, please feel free to merge.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants