This repository has been archived by the owner on Oct 4, 2019. It is now read-only.
core/state: Fix memory expansion bug by not copying clean objects #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We need to define a process, I think at least two other committers (who committed before in the repo) should make code review and write in comments if they accept the commit. Right now it's only @whatisgravity, so we need to find another experienced Go developer to make reviews. At least two people should write their comment for a PR, and PR author shouldn't merge his PR by himself. Right now we don't know what this commit does, nobody reviewed it. I don't see any tests for it, we don't even sure what it fixes and where it comes from (provided link doesn't work). Also I afraid it can break our upstream merging process. |
soc1c
added a commit
that referenced
this pull request
Aug 13, 2019
* Replace repository reference for accounts/abi/bind (#29) * docs: update badges (#34) * docs: add gitter badge * docs: add circle-ci badge * Update README.md * Update README.md * Update README.md * docs: update repository path * Update README.md * Tx Encoding and decoding fix (#33) * Added test for decoding old encoding function * Fixed decoding issue and improved tests to handle all cases including previous client * Add compatibility with previous version * Rename receipt storage variable * Storage and edge case fixes (#28) * Applied storage fixes and updates * Minor execution refactor
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-picked from ethereum/go-ethereum@62f86a7
testing resync now