Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typo in error message #3822

Closed
bomb-on opened this issue Feb 23, 2023 · 2 comments
Closed

Typo in error message #3822

bomb-on opened this issue Feb 23, 2023 · 2 comments
Assignees
@ricmoo
Labels
fixed/complete This Bug is fixed or Enhancement is complete and published. v6 Issues regarding v6

Comments

@bomb-on
Copy link

bomb-on commented Feb 23, 2023 •
edited
Loading

Ethers Version

6.0.5

Search Terms

No response

Describe the Problem

Just a simple typo in error message, invlaid instead of invalid in few places in fragments.ts file: L692, L701, L715, L741.

typo

Code Snippet

No response

Contract ABI

No response

Errors

No response

Environment

node.js (v12 or newer)

Environment (Other)

No response
@bomb-on bomb-on added investigate Under investigation and may be a bug. v6 Issues regarding v6 labels Feb 23, 2023
@bomb-on
Copy link
Author

bomb-on commented Feb 23, 2023

And another typo in docs (parasing instead of parsing), https://github.com/ethers-io/ethers.js/blob/main/docs.wrm/migrating.wrm#L239

@rtt63 rtt63 mentioned this issue Feb 23, 2023
Closed
@ricmoo ricmoo added on-deck This Enhancement or Bug is currently being worked on. and removed investigate Under investigation and may be a bug. labels Feb 24, 2023
ricmoo added a commit that referenced this issue Mar 4, 2023
@ricmoo
Fixed typo in error messages (#3822, #3824).
f1a810d
@ricmoo
Copy link
Member

ricmoo commented Mar 7, 2023

I fixed the invalid typos and it is published, and just noticed your comment regarding parsing, which is fixed locally and will go out on the next push.

Thanks! :)

@ricmoo ricmoo closed this as completed Mar 7, 2023
@ricmoo ricmoo added fixed/complete This Bug is fixed or Enhancement is complete and published. and removed on-deck This Enhancement or Bug is currently being worked on. labels Mar 7, 2023
Woodpile37 pushed a commit to Woodpile37/ethers.js that referenced this issue Jan 14, 2024
@ricmoo @Woodpile37
Fixed typo in error messages (ethers-io#3822, ethers-io#3824).
8448e12
Woodpile37 pushed a commit to Woodpile37/ethers.js that referenced this issue Jan 14, 2024
@ricmoo @Woodpile37
Fixed typo in error messages (ethers-io#3822, ethers-io#3824).
3cef83f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ricmoo ricmoo

Labels
fixed/complete This Bug is fixed or Enhancement is complete and published. v6 Issues regarding v6
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ricmoo @bomb-on