Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typo in exception at 's' prop of Signature #3891

Closed
robbelouwet opened this issue Mar 11, 2023 · 2 comments
Closed

Typo in exception at 's' prop of Signature #3891

robbelouwet opened this issue Mar 11, 2023 · 2 comments
Labels
documentation Documentation related issue. fixed/complete This Bug is fixed or Enhancement is complete and published. v6 Issues regarding v6

Comments

@robbelouwet
Copy link

Suggestion

ethers.js/src.ts/crypto/signature.ts

Lines 80 to 85 in 278f841

/**
* The ``s`` value for a signature.
*/
get s(): string { return this.#s; }
set s(_value: BytesLike) {
assertArgument(dataLength(_value) === 32, "invalid r", "value", _value);

Should be 'invalid s'?
@robbelouwet robbelouwet added the documentation Documentation related issue. label Mar 11, 2023
@robbelouwet robbelouwet changed the title Documentation Title Typo documentation 's' prop of Signature Mar 11, 2023
@robbelouwet robbelouwet changed the title Typo documentation 's' prop of Signature Typo in exception at 's' prop of Signature Mar 11, 2023
@ricmoo
Copy link
Member

ricmoo commented Mar 11, 2023

Yes. Yes it should. :)

Thanks!

@ricmoo ricmoo added on-deck This Enhancement or Bug is currently being worked on. v6 Issues regarding v6 labels Mar 11, 2023
@Coollaitar Coollaitar mentioned this issue Mar 12, 2023
Closed
ricmoo added a commit that referenced this issue Mar 20, 2023
@ricmoo
Fixed typo in signature.s error (#3891).
47ef3eb
@ricmoo
Copy link
Member

ricmoo commented Mar 20, 2023

Fixed in v6.2.0.

Thanks! :)

@ricmoo ricmoo closed this as completed Mar 20, 2023
@ricmoo ricmoo added fixed/complete This Bug is fixed or Enhancement is complete and published. and removed on-deck This Enhancement or Bug is currently being worked on. labels Mar 20, 2023
Woodpile37 pushed a commit to Woodpile37/ethers.js that referenced this issue Jan 14, 2024
@ricmoo @Woodpile37
Fixed typo in signature.s error (ethers-io#3891).
44dd4c7
Woodpile37 pushed a commit to Woodpile37/ethers.js that referenced this issue Jan 14, 2024
@ricmoo @Woodpile37
Fixed typo in signature.s error (ethers-io#3891).
584526a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation Documentation related issue. fixed/complete This Bug is fixed or Enhancement is complete and published. v6 Issues regarding v6
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Typo in exception at 's' prop of Signature Solved Coollaitar/ethers.js
2 participants
@ricmoo @robbelouwet