-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Did the 'error' event listener get removed in v6, like provider.on('error', () => {})? #3970
Comments
This seems to be similar and / or related to #3952 |
@ricmoo what happened to ProviderEvents? they seem all gone... (same behavior with 6.3.0) |
This will be added in the next minor version. I'm currently trying to figure out the best way to abstract all the possible ways things can go wrong, so an extendable type can be provided for future internal errors. |
Thank you, any workaround meanwhile? use |
Is there any update about this problem? I am still facing same issue. |
It’s fixed in main, but not published yet. There are two small issues I want to include in the minor bump that fixes this. Should be published on npm soon. |
These hidden errors are a real showstopper, is there anything I can help you with so that the release can be published? 🙂 I'm also concerned about this "error handling" for listeners, both for the high-level api and the low-level api: ethers.js/src.ts/contract/contract.ts Line 583 in 1359380
ethers.js/src.ts/providers/abstract-provider.ts Line 1188 in 1359380
And especially this:
I simulate a serious problem by restarting my hardhat test network. Then the whole application gets stuck and there is no way to recover from this bogus state:
Errors are silently catched everywhere and there is also no global |
Added in v6.4.0. Thanks! :) |
Event after updating to v6.4.0 the issue is still there |
I’ll look into this in the morning. |
Is this still pending? |
Did you fix? |
Using v6.13.2 I'm still getting the error. It only seems present using a local hardhat node, so I suspect that "non-iterable results" happens when no transaction is made on the block. That would explain why it won't happen in production as several transactions are available on every new block. |
Ethers Version
6.2.3
Search Terms
No response
Describe the Problem
Did the 'error' event listener get removed in v6, like provider.on('error', () => {})?
Code Snippet
Contract ABI
No response
Errors
Environment
No response
Environment (Other)
No response
The text was updated successfully, but these errors were encountered: